Skip to content

feat: Implement wrappers for MPI_Gatherv #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2025
Merged

Conversation

adit4443ya
Copy link
Collaborator

Towards #121

MPI_Gatherv is a collective communication routine in MPI that gathers data from all processes in a communicator to a single process (the root process).

@adit4443ya adit4443ya requested a review from gxyd May 20, 2025 05:41
Copy link
Collaborator

@gxyd gxyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any problem with what we've in this PR for MPI_Gatherv, but what I would like to see is MPI_Gatherv wrapper for how it's used in pFUnit repository.

i.e. I see that in pFUnit it's use case is something like:

      call Mpi_GatherV( &
           & sendBuffer, numEntries, MPI_CHARACTER, &
           & recvBuffer,   counts, displacements, MPI_CHARACTER, &
           & this%root, this%mpiCommunicator, ier)

@adit4443ya adit4443ya added the enhancement New feature or request label May 20, 2025
Copy link
Collaborator

@gxyd gxyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me.

@gxyd gxyd merged commit 2cdaf6f into lfortran:main May 21, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants